<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Jan 5, 2009, at 11:37 AM, Misha Brukman wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">2009/1/1 Chris Lattner <span dir="ltr"><<a href="mailto:clattner@apple.com" target="_blank">clattner@apple.com</a>></span><br><div class="gmail_quote"><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> <div> On Jan 1, 2009, at 1:21 AM, Talin wrote:<br> > I'm thinking that getting unit tests for the classes in ADT should<br> > be an early goal.<br> <br> </div>Can I suggest the AP[S]Int class? If you look in llvm/test/Integer<br> you'll see a whole bunch of tests that really want to be unit tests<br> but that aren't. :(</blockquote><div><br>Chris, do you mean *all* the .ll files in that dir should become unittests, or are you talking about some specific files that should be unittests, and others that should stay as llvm-as/llvm-dis tests?<br> <br>I'm assuming a##.* are prime candidates, what about the others? Are the double llvm-as/llvm-dis tests about bitcode printing/parsing or are they really testing some auto-simplification built-in to the APSInt class?<br> </div></div></blockquote></div><br><div>Oh, sorry, I just meant the "a*" tests, which are basically doing constant folding (but not checking the results!)</div><div><br></div><div>-Chris</div></body></html>