Hi Tanya,<br>See my comments in line,<br><div class="gmail_quote">On Tue, Jul 8, 2008 at 3:25 AM, Tanya M. Lattner <<a href="mailto:tonic@nondot.org">tonic@nondot.org</a>> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
Rajika,<br>
<br>
A couple of comments:<br>
<br>
- You should provide a way to specify where llvm-gcc is built (just like<br>
llvm).</blockquote><div>I think this is given by LLVMGCCDIR . And also what about the location where the actual llvm-source is kept(which will be updated by the script) ?<br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
<br>
- I would highly recommend allowing the user to only update llvm-gcc and<br>
not check it out from scratch each time. Checking out llvm-gcc is very<br>
time consuming.</blockquote><div> </div><div>So where should we maintain the llvm-source tree in a localmachine, so that the script will update that copy? Are we going to get that location using an ENV varible ? And the installtion path will be given by LLVMGCCDIR, or to a default location if it is not set.<br>
</div><div><br><br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">You would need to make sure that llvm and llvm-gcc have<br>
the same rev number and nuke the llvm obj/install dirs so you get a clean<br>
build. Sure svn issues can happen, but they are rare and your script<br>
changes should be able to catch those errors.</blockquote><div>I can keep track of the revision number of llvm and llvm-gcc once they different from each other I can throw an error, but why should they be synchronised to be the same revision number? I am still not clear how that(i.e. each of the revision number in llvm and llvm-gcc of course) affect the llvm-gcc build. <br>
</div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><br>
<br>
- Remove the cvs stuff, its dead. Feel free to clean up the<br>
script and remove ALL cvs stuff.</blockquote><div>Sure I'll do this and I'll be renaming all the CVS stuffs into SVN ex: the SVN check out log is still CVS-Log.txt(it will be SVN-Log.txt etc..)<br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
<br>
- I think if LLVM_GCC_CONFIGURE is set and the flag -nollvmgcc is not set,<br>
you should throw an error.</blockquote><div>Well what if a user has a value for the environment varible LLVM_GCC_CONFIGURE but he doesn't want to build the llvm-gcc tree ? <br>What I thought was if a user needs to build llvm-gcc he/she should set -nollvmgcc flag, if it going to happens in the normal way (i.e. they buid llvm, llvm-gcc, test etc.., all the time) we can simply drop this flag. I added this following -nobuild flag for llvm. <br>
Or simply if a user set -nobuild flag we can simply build neither llvm nor llvm-gcc ?<br><br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
<br>
- You should not try to add the configure options yourself, this is not<br>
worth it in my opinion (maybe in the future if you want to base it off the<br>
target triple or something) but for now.. keep it simple. You should only<br>
add the --enable-llvm since only the script knows where its built.</blockquote><div>Ok <br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
<br>
- What happens if LLVMGCCDIR is set?</blockquote><div> </div><div>So that , that LLVMGCCDIR will be used to install the llvm-gcc, discarding the normal default location sepecified by the user (see above)<br><br><br></div>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> It will use that over the llvm-gcc<br>
you have built.</blockquote><div> </div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> In fact, I don't think you have reconfigured llvm at all<br>
after building llvm-gcc.</blockquote><div>You mean to run the Deja GNU tests right? . OK I'll add that part as well <br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
<br>
- Checkout to something more meaningful then dst-directory.</blockquote><div>What about llvm-gcc as Bill suggested ? <br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
<br>
- We don't care about warnings, file sizes or loc of llvm-gcc. If you want<br>
to keep any stats you can keep track of config, build times, and build<br>
status. The rest is stuff we don't really want to track in the database<br>
(too much info!).</blockquote><div>Ok, I'll not worry about LOC of llvm-gcc etc.. <br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
<br>
Also, how have you tested this??</blockquote><div>Yeah, I ran it (with -nosubmit) and had a look at the output.log which indicates the values of the newly added varibles for llvm-gcc. <br>And I have the following TEXT files under tests results directory.<br>
<br> 2008-07-07-Build-Log.txt<br> 2008-07-07-CVS-Log.txt<br> 2008-07-07-Dejagnu-testrun.log<br> 2008-07-07-Dejagnu-testrun.sum<br> 2008-07-07-DejagnuTests-Log.txt<br> 2008-07-07-LLVMGCC-Build-Log.txt<br> 2008-07-07-LLVMGCC-Warnings.txt<br>
2008-07-07-MultiSource-Performance.txt<br> 2008-07-07-MultiSource-ProgramTest.txt<br> 2008-07-07 23:11 2008-07-07-MultiSource-Tests.txt<br> 2008-07-07 23:14 2008-07-07-Olden-tests.txt<br> 2008-07-07 23:11 2008-07-07-Performance.txt<br>
2008-07-07 23:04 2008-07-07-SingleSource-Performance.txt<br> 2008-07-07-SingleSource-ProgramTest.txt<br> 2008-07-07-SingleSource-Tests.txt<br> 2008-07-07-Tests.txt<br> 2008-07-07-Warnings.txt<br><br>In which LLVMGCC-* are the newly created result files for LLVM-GCC build.<br>
<br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> Where is the patch to the DB schema and<br>
accept scripts?</blockquote><div> </div><div>I didn't look into the server side yet, will send that patch soon. <br></div><div><br>Thanks for the comments and help. I'll attacch the updated patch soon.<br><br>-Rajika <br>
</div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><br>
<font color="#888888"><br>
-Tanya<br>
</font><div><div></div><div class="Wj3C7c"><br>
On Mon, 7 Jul 2008, Rajika Kumarasiri wrote:<br>
<br>
> hello everybody,<br>
><br>
> I have added few improvements to my patch. Please review the new patch<br>
> directly.<br>
> Thanks!<br>
><br>
> -Rajika<br>
><br>
> On Sun, Jul 6, 2008 at 9:17 PM, Rajika Kumarasiri <<a href="mailto:rajikacc@gmail.com">rajikacc@gmail.com</a>><br>
> wrote:<br>
><br>
>> hello every body.<br>
>><br>
>> Here with I have attached the patch which compile the llvm-gcc using<br>
>> nightly tester script. This patch add the following capabilities to the<br>
>> NewNightlyTester.pl script.<br>
>><br>
>> 1. Checkout the llvm-gcc4.2 source from the SVN.<br>
>> 2. Compile the checkout llvm-gcc4.2 source tree.<br>
>> 3. Gather the configure/make out put informations.<br>
>> 4. Add the (3) informations to the %hash_of_data hash to be posted to the<br>
>> server, of course for further processing.<br>
>><br>
>> Please review the patch and let me know your comments. There are few small<br>
>> TODOs (ex: get the LOC of llvm-gcc etc..,) to be added. I'll update the<br>
>> patch with that soon.<br>
>><br>
>> Thank you<br>
>><br>
>> -Rajika<br>
>><br>
>> --<br>
>> comp.lang.c - <a href="http://groups.google.com/group/comp.lang.c/topics" target="_blank">http://groups.google.com/group/comp.lang.c/topics</a><br>
><br>
><br>
><br>
><br>
><br>
</div></div><div><div></div><div class="Wj3C7c">_______________________________________________<br>
LLVM Developers mailing list<br>
<a href="mailto:LLVMdev@cs.uiuc.edu">LLVMdev@cs.uiuc.edu</a> <a href="http://llvm.cs.uiuc.edu" target="_blank">http://llvm.cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev</a><br>
</div></div></blockquote></div><br><br clear="all"><br>-- <br>comp.lang.c - <a href="http://groups.google.com/group/comp.lang.c/topics">http://groups.google.com/group/comp.lang.c/topics</a>