<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Committed. Thanks!<div><br></div><div>Evan</div><div><br><div><html>On Mar 23, 2008, at 4:39 AM, Jay Freeman (saurik) wrote:</html><br class="Apple-interchange-newline"><blockquote type="cite"><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0; "><div bgcolor="#ffffff"><div><font face="Arial" size="2">So, a while back I got a compile error where the assembly was missing some whitespace between a .set and the identifier and tracked it down to this simple mistake that I just verified is still in the tree:</font></div><div><font face="Arial" size="2"></font> </div><div><font face="Arial" size="2">Index: lib/Target/ARM/ARMTargetAsmInfo.cpp<br>===================================================================<br>--- lib/Target/ARM/ARMTargetAsmInfo.cpp (revision 48700)<br>+++ lib/Target/ARM/ARMTargetAsmInfo.cpp (working copy)<br>@@ -49,7 +49,7 @@<br> PrivateGlobalPrefix = "L";<br> BSSSection = 0; // no BSS section.<br> ZeroFillDirective = "\t.zerofill\t"; // Uses .zerofill<br>- SetDirective = "\t.set";<br>+ SetDirective = "\t.set\t";<br> WeakRefDirective = "\t.weak_reference\t";<br> HiddenDirective = "\t.private_extern\t";<br> ProtectedDirective = NULL;<br></font></div><div><font face="Arial" size="2">I unfortunately don't have the code that died anymore (it was a couple months ago, and I'm unfortunately just now getting on this mailing list to report the issue), but it seems pretty obvious from the surrounding context to be wrong, and there's even another initialization of SetDirective in the same file that _does_ have the traililng \t.</font></div><div><font face="Arial" size="2"></font> </div><div><font face="Arial" size="2">Sincerely,</font></div><div><font face="Arial" size="2">Jay Freeman (saurik)</font></div><div><font face="Arial"><font size="2"><a href="mailto:saurik@saurik.com">saurik@saurik.com</a></font></font></div><div><font face="Arial"><font size="2"><a href="http://www.saurik.com/">http://www.saurik.com/</a></font></font></div><font face="Arial"></font>_______________________________________________<br>LLVM Developers mailing list<br><a href="mailto:LLVMdev@cs.uiuc.edu">LLVMdev@cs.uiuc.edu</a> <a href="http://llvm.cs.uiuc.edu">http://llvm.cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev">http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev</a><br></div></span></blockquote></div><br></div></body></html>