<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 TRANSITIONAL//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; CHARSET=UTF-8">
<META NAME="GENERATOR" CONTENT="GtkHTML/3.0.9">
</HEAD>
<BODY>
Consider it done. I really only care about the header files anyway :)<BR>
<BR>
Reid<BR>
<FONT COLOR="#301fe4"><I> </I></FONT><BR>
On Sat, 2003-11-15 at 16:11, Chris Lattner wrote:
<BLOCKQUOTE TYPE=CITE>
<PRE><FONT COLOR="#301fe4"><I>On Sat, 15 Nov 2003, Reid Spencer wrote:
> In compiling my software to use LLVM, I have noticed many occurrences of
> C style casting in LLVM header files. Since I compile with the
> -Wold-style-cast flag to g++, I get warnings about each of them. This
> isn't a big deal but I try to keep my code compilations both error
> and warning free (makes spotting true errors easier).
Ah, ok, we never have used that flag. :)
> I'm wondering why a new C++ (LLVM) would choose to use C style casting?
> Wouldn't it be safer/clearer to use C++ style casting?
Force of habit I gues...
> These occur pretty much only in Support/Casting.h and llvm/Use.h. They
> may occur elsewhere but these are the only ones I've found so far.
I have no problem with fixing this, though I would prefer to do it
incrementally as opposed to a monster patch. If you want to prepare
a patch for just the header files, I would have no problem with it...
-Chris</I></FONT></PRE>
</BLOCKQUOTE>
</BODY>
</HTML>