[llvm-dev] [InstCombine] Addrspacecast and GEP assumed commutative

[Anna Thomas via llvm-dev]

Hi Thomas,

We hit on this issue internally with GEP and addrspacecast being reordered. Curious if you have a patch out for review?

Thanks,
Anna
On Mar 24, 2020, at 10:23 AM, Matt Arsenault via llvm-dev <llvm-dev at lists.llvm.org<mailto:llvm-dev at lists.llvm.org>> wrote:



On Mar 24, 2020, at 08:50, Thomas Faingnaert <thomas.faingnaert at hotmail.com<mailto:thomas.faingnaert at hotmail.com>> wrote:

It appears that this behaviour of InstCombine is at least somewhat intended, as there are several tests that fail after the change mentioned before: cast.ll,gep-addrspace.ll and getelementptr.ll in test/Transforms/InstCombine.
I feel a little uncomfortable applying the patch after knowing this, and removing those tests doesn't seem like a great solution.
What are your thoughts?

These are checking for the current behavior, it’s only natural tests would need updating for this change. You should just update them to show the new result

-Matt
_______________________________________________
LLVM Developers mailing list
llvm-dev at lists.llvm.org<mailto:llvm-dev at lists.llvm.org>
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20200331/f9528b4f/attachment-0001.html>