[llvm-dev] [Incubation] Request to incubate mlir-npcomp

Mehdi AMINI via llvm-dev llvm-dev at lists.llvm.org
Wed Jun 24 10:35:44 PDT 2020


On Wed, Jun 24, 2020 at 9:54 AM Nicolai Hähnle via llvm-dev <
llvm-dev at lists.llvm.org> wrote:

> On Tue, Jun 23, 2020 at 2:40 PM Stella Laurenzo via llvm-dev
> <llvm-dev at lists.llvm.org> wrote:
> > We originally started it as a fork of the LLVM repository, but
> transitioned to the MLIR standalone template, and we found it more
> productive to iterate out of tree in this fashion, bumping to the latest
> LLVM version every week or so as needed (note: the ability to exist out of
> tree for MLIR dependent projects is actually quite good, and the more of us
> who do it, the better it becomes).
>
> How do you deal with the problem of using the "right" LLVM version? As
> somebody who spends a significant amount of time on a project that is
> open-source but out-of-tree -- and for good reasons that mean we're
> unlikely to want to incubate in this fashion -- I find this to be a
> major problem.
>
> If the goal of incubation is to eventually become part of the
> llvm-project monorepo, I feel that being inside the monorepo should be
> a goal early on. This would make your project more inclusive, as
> others will automatically have the right LLVM version -- they don't
> have to follow some syncing mechanism that you may have tooling for
> inside of Google but which isn't available outside.


There is nothing specific to Google, quite the opposite actually: the
"update once a week" here is purely OSS and does not work inside Google.



> You can always
> "bump to the latest LLVM version every week or so" by doing a merge
> commit.
>

I'm not sure I perceive how having code that is a "read-only" mirror (the
LLVM monorepo) mixed within the project repo would be helping to be "more
inclusive"?
Not duplicating the monorepo helps to ensure that you don't diverge from
the rest of LLVM by patching it (you're losing flexibility in the
development of course, but then shouldn't this just be in the monorepo in
the first place?)

But it also seems to me that we're spreading the discussion on the "right
template" between the incubator thread and this particular proposal, which
does not help to keep track.

-- 
Mehdi


>
> Cheers,
> Nicolai
>
>
> --
> Lerne, wie die Welt wirklich ist,
> aber vergiss niemals, wie sie sein sollte.
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20200624/4bcb6f22/attachment.html>


More information about the llvm-dev mailing list