[llvm-dev] FileCheck

[Joel E. Denny via llvm-dev]

On Thu, Jun 18, 2020 at 2:40 PM Chris Lattner <clattner at nondot.org> wrote:

>
>
> On Jun 18, 2020, at 11:36 AM, Matt Arsenault <arsenm2 at gmail.com> wrote:
>
>
>
> On Jun 18, 2020, at 14:32, Chris Lattner via llvm-dev <
> llvm-dev at lists.llvm.org> wrote:
>
> 2) Instead of dumping the entire input by default, would it be reasonable
> to change the default “make check” to have  FileCheck print the 10 lines
> before and after the mismatch?  Most problems are close by the check
> failure.  If you want to check extra fancy, dump the CHECK-LABEL region.
>
>
> In my experience, the entire CHECK-LABEL region is still way too much
> (e.g. MIR tests print a giant block of function information in the prolog).
> There needs to be a stricter line count clamping of some kind
>
>
> Sure, what I’m actually advocating here is a pile of heuristics that work
> well for humans: e.g. dump the label region if it is 20 lines or less.  If
> it is large, then look at where the last match and the fuzzy next match
> are, and include that, .. etc.  FileCheck has a lot of information that
> we’re not using and some elbow grease could make the default experience way
> nicer for humans.
>

This kind of info is stored in the input-line annotations produced by -vv
(when combined with -dump-input).  I think it's just a matter of filtering
lines based on those annotations.

Joel


> -Chris
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20200618/3c52dead/attachment-0001.html>