[llvm-dev] [cfe-dev] Phabricator -> GitHub PRs?

David Greene via llvm-dev llvm-dev at lists.llvm.org
Wed Jan 22 12:58:35 PST 2020


Renato Golin via cfe-dev <cfe-dev at lists.llvm.org> writes:

>> My understanding from other people's comments (I've not tried it myself) is that updating a patch series in github is problematic - that it sends new/separate review email rather than being able to associate each patch in the series with ongoing review feedback and updates?
>
> Both Phab and GitHub are problematic in different ways. In Phab, an
> earlier change that trickles to the rest of the series needs to be
> updated on all patches. In GitHub, some information is lost,
> especially if it's a force push, but it only sends one email for the
> series.

Isn't force push on a private branch (series) going to be rather common
as authors respond to reviews?  Or is there a better model?

                      -David


More information about the llvm-dev mailing list