[llvm-dev] [tablegen] table readability / performance

Luke Drummond via llvm-dev llvm-dev at lists.llvm.org
Mon Jan 20 07:01:20 PST 2020


Hi Reid, Martin

On Wed Jan 15, 2020 at 9:28 PM, Reid Kleckner wrote:
> It would. In this case, we would need to add CMake logic to pass the
> option
> when running tablegen. I'm not sure how to detect this precise case,
> though.
>

Okay. I think I managed a reasonable middle-ground. By default, if
cross-compiling or running cmake with Visual Studio, emit char literal
arrays, otherwise string literals. The user can override at runtime with
a switch.

I've pushed a patch to phab: https://reviews.llvm.org/D73044

Please tag any extra reviewers who may be interested.

Thanks for the input.

All the Best

Luke

-- 
Codeplay Software Ltd.
Company registered in England and Wales, number: 04567874
Registered office: Regent House, 316 Beulah Hill, London, SE19 3HF


More information about the llvm-dev mailing list