[llvm-dev] [RFC] IRBuilder polymorphism: Templates/virtual

Nicolai Hähnle via llvm-dev llvm-dev at lists.llvm.org
Tue Feb 11 06:50:04 PST 2020


Nikita posted some performance comparisons on the Phabricator review
https://reviews.llvm.org/D73835, results here:
https://gist.github.com/nikic/9a87083358d98f34e8e64851a84ff864

It seems like the difference in compile time is in the noise.

Cheers,
Nicolai

On Mon, Feb 10, 2020 at 9:35 PM Michael Kruse <llvmdev at meinersbur.de> wrote:
>
> Am Do., 6. Feb. 2020 um 04:07 Uhr schrieb Nicolai Hähnle via llvm-dev
> <llvm-dev at lists.llvm.org>:
> > I am in favor of this, for all the reasons you mention. In fact, I was
> > tempted to do this myself in the past. This is particularly an issue
> > for external tools that want to leverage LLVM without forking the
> > upstream, which is a usecase that LLVM should support better.
> >
> > Generally, I think LLVM errs too much on the side of monomorphizing
> > everything, which sounds nice in theory, but the runtime performance
> > implications are often questionable, and the compile time certainly
> > suffers. I think we should take some time to think through the details
> > of this change, but we should make it.
>
> +1



-- 
Lerne, wie die Welt wirklich ist,
aber vergiss niemals, wie sie sein sollte.


More information about the llvm-dev mailing list