[llvm-dev] Adopting a third-party JSON library

Michael Kruse via llvm-dev llvm-dev at lists.llvm.org
Thu Aug 20 10:38:20 PDT 2020


lib/Support/JSON.cpp has been written because the community did not want to
add an external dependency or copy a 3rd party JSON library. See
http://lists.llvm.org/pipermail/llvm-dev/2017-October/118583.html for th
discussion. Since JSON.cpp now is integrated in the codebase, there now is
even less reason to switch to a 3rd party implementation.

Michael

Am Di., 18. Aug. 2020 um 22:31 Uhr schrieb Filippo Costa via llvm-dev <
llvm-dev at lists.llvm.org>:

> Hi,
> I'm a new contributor. I'm considering the possibility of adopting a
> third-party JSON library instead of LLVM's homegrown
> `lib/Support/JSON.cpp`. The way I see it, this would bring several
> advantages as well as some downsides:
>
>  + Slimmer codebase.
>  + Benefit from upstream work and active contributions to another project.
>  + Possibly improved performance and API ergonomics.
>  - Likely compile times regression as many JSON libs are header-only.
>  - Risk of introducing bugs and breakages across LLVM.
>
> As far as I can tell, these are the most popular C++ JSON libs:
>
>  * https://github.com/nlohmann/json
>  * https://github.com/open-source-parsers/jsoncpp
>  * https://github.com/Tencent/rapidjson
>
> I'm trying to understand if this is something I should work on and whether
> or not it would benefit the project.
>
> Filippo Costa
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20200820/6c2060ae/attachment.html>


More information about the llvm-dev mailing list