[llvm-dev] Make llvm-commits default cc on Phabricator

Jinsong Ji via llvm-dev llvm-dev at lists.llvm.org
Fri Apr 24 12:01:13 PDT 2020


+1


Another problem of not setting “Repository”  to `rG LLVM Github Monorepo`
is: the patch generated by `Download Raw Diff` will NOT be a "real" patch.


It won't contain `diff --git ` commands, so you can NOT apply it directly.



Best,

Jinsong Ji (纪金松), PhD.

XL/LLVM on Power Compiler Development
E-mail: jji at us.ibm.com



From:	Roman Lebedev via llvm-dev <llvm-dev at lists.llvm.org>
To:	Alexandre Ganea <alexandre.ganea at ubisoft.com>
Cc:	LLVM Dev <llvm-dev at lists.llvm.org>
Date:	04/24/2020 02:46 PM
Subject:	[EXTERNAL] Re: [llvm-dev] Make llvm-commits default cc on
            Phabricator
Sent by:	"llvm-dev" <llvm-dev-bounces at lists.llvm.org>



On Fri, Apr 24, 2020 at 9:43 PM Alexandre Ganea via llvm-dev <
llvm-dev at lists.llvm.org> wrote:
  Hello,





  I sometime forget to set the “Repository” when uploading a patch on
  Phabricator, and that prevents from adding llvm-commits as a subscriber.








  Would it make sense to set ‘LLVM Github Monorepo’ as a default?


+1 Now that git monorepo is the one true source of truth that is the only
sane default.

  Or subscribe ‘llvm-commits’ automatically when creating a patch?


I think that would also make sense.

  Thanks!


  Alex.


Roman

  _______________________________________________
  LLVM Developers mailing list
  llvm-dev at lists.llvm.org
  https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
  _______________________________________________
  LLVM Developers mailing list
  llvm-dev at lists.llvm.org
  https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_llvm-2Ddev&d=DwIGaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=DvnnfavFQBGT2CDyHzTr_Q&m=-50VDf3xr1TCxsA_-5YTBODQdX4w4-dbqvMah_YD3K0&s=24zVYhaeBrhFEJBkoryFiy4kohXxL7w-RgnrZfk7gpk&e=



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20200424/c3d77285/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: graycol.gif
Type: image/gif
Size: 105 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20200424/c3d77285/attachment.gif>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 48351733.gif
Type: image/gif
Size: 3097 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20200424/c3d77285/attachment-0001.gif>


More information about the llvm-dev mailing list