[llvm-dev] MLIR landing in the monorepo

[David Greene via llvm-dev]

Mehdi AMINI <joker.eph at gmail.com> writes:

>> The default mode of operation does exactly what James says here.  It
>> rewrites the commits so all blobs are under a specific subdirectory.
>> Then you can do a merge from the rewritten MLIR HEAD.
>>
>
> I used `git-filter-repo`, but that is exactly what I've been doing actually.

Great!

>> With default operation, a checkout of an early MLIR commit would should
>> only an "mlir" directory in the working directory.
>
>
> Right that what I have right now in the repo, for example:
> https://github.com/joker-eph/llvm-project-with-mlir/tree/291a8e7ca113c4a8fc597fc0ec1a3a4e4e639f78

Ok.

>> With --import-list
>> you'd see all of the other subproject directories, though the contents
>> of those other directories wouldn't change as you walked back through
>> early MLIR history.
>>
>
> OK, but that seems like a "wrong" history: the state would seem quite
> misleading to me by mixing a recent LLVM with an old MLIR (and the code
> wouldn't be able to build successfully at any of these revisions).
> Can you clarify why would you prefer this over just a single `mlir`
> directory?

I don't necessarily prefer it, I was just pointing it out as an option.
I'd be perfectly happy going with what you've got now!

                 -David