[llvm-dev] RFC: LLVM Build System Future Direction

Chris Bieneman via llvm-dev llvm-dev at lists.llvm.org
Sun Nov 3 10:09:53 PST 2019


Dave,

We would keep the ability to specify source paths for things that live outside the mono-repo, just not for things inside the repository. This would have the impact of supporting `LLVM_EXTERNAL_*_SOURCE_DIR` for projects specified in `LLVM_EXTERNAL_PROJECTS` but not projects specified with `LLVM_ENABLE_PROJECTS`.

Does that address your concerns?

-Chris

> On Oct 30, 2019, at 6:37 AM, David Zarzycki via llvm-dev <llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>> wrote:
> 
> 
> 
>> On Oct 29, 2019, at 7:09 PM, Chris Bieneman via llvm-dev <llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>> wrote:
>> 
>> There was also agreement that in the monorepo it no longer makes sense to have an option to specify the source locations of sub-projects. That means we can remove the `LLVM_EXTERNAL_*_SOURCE_DIR` variables.
>> 
> 
> Hi Chris,
> 
> What about genuine external projects? For example, I build Swift “unified” as a part of LLVM but I can’t keep the Swift source inside of the llvm-project directory due to how Git submodules work. In other words:
> 
> $ cd my_project
> $ ls toolchain
> cmark
> llvm-project
> swift
> $ git submodule status
>  bfa95d55b535fa178f75484b5e8f82ae3d8517af toolchain/cmark
>  ea51a1ab2980d055c68820888ce255242f387c91 toolchain/llvm-project
> +cec05255029d0ce354825e5530a47a5affb03975 toolchain/swift 
> 
> Dave
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20191103/e8803743/attachment-0001.html>


More information about the llvm-dev mailing list