[llvm-dev] FYI: LLVM Phabricactor notifications.

Tom Stellard via llvm-dev llvm-dev at lists.llvm.org
Wed Jun 26 07:28:31 PDT 2019


On 05/31/2019 12:54 AM, Manuel Klimek wrote:
> We should be able to control the noise of these, but I also wonder whether we can switch to github reviews as part of the git move :)
> (we just lost our long time phab maintainer on the team)
> 

Hi,

Were we ever able to resolve this issue?

I'm trying to test a GitHub app that auto-closes pull requests, and
I'm also seeing excessive notifications from Phabricator.  Every time
someone commits a new patch, the pull requests seems to get rebased
behind the scenes and I get a new commit notification.

Thanks,
Tom

> On Fri, May 31, 2019 at 12:44 AM Shoaib Meenai via llvm-dev <llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>> wrote:
> 
>     I believe (and I believe it was James who pointed this out on IRC) that Phabricator pulls in all refs, and GitHub stores PR commits under refs/pull.
> 
>     ´╗┐On 5/30/19, 3:37 PM, "llvm-dev on behalf of Tom Stellard via llvm-dev" <llvm-dev-bounces at lists.llvm.org <mailto:llvm-dev-bounces at lists.llvm.org> on behalf of llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>> wrote:
> 
>         On 05/30/2019 10:04 AM, Sachkov, Alexey via llvm-dev wrote:
>         > +llvm-dev
>         >
>         > 
>         >
>         > *From:* cfe-dev [mailto:cfe-dev-bounces at lists.llvm.org <mailto:cfe-dev-bounces at lists.llvm.org>] *On Behalf Of *Bader, Alexey via cfe-dev
>         > *Sent:* Thursday, May 30, 2019 7:31 PM
>         > *To:* clang-dev developer list <cfe-dev at lists.llvm.org <mailto:cfe-dev at lists.llvm.org>>
>         > *Subject:* [cfe-dev] FYI: LLVM Phabricactor notifications.
>         > *Importance:* Low
>         >
>         > 
>         >
>         > Hi,
>         >
>         > 
>         >
>         > I think some of contributors to the Clang received a notifications about some commits done in the past.
>         >
>         > I wanted to share my thoughts on why it might has happened.
>         >
>         > 
>         >
>         > I think the commits from this PR https://github.com/llvm/llvm-project/pull/13were pulled by Phabricator (probably with aim to review GitHub pull requests in https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=AD-hZ9rLcmVgzhl1TFTAvKbX-nrgHD75y9sqN5zTEsg&s=KaCscc77Z-fBuYo2dCuykCeHg35yKQXRwp6uVuIsPos&e= environment).
>         >
>         > 
>         >
>         > The PR has 2000+ commit, most of which are some old commits from the master branch, and when Phabricator pulled the commits from PR, it sent a notification to the commit author (or committer).
>         >
>         > 
>         >
>         > Probably we can do something to avoid this situation in the future.
>         >
>         > 
> 
>         + Manuel, Chandler
> 
>         Any idea what happened here? Is phabricator setup to automatically import
>         pull requests? 
> 
>         -Tom
> 
>         >
>         > Sorry for the inconvenience.
>         >
>         > 
>         >
>         > Alexey
>         >
>         > 
>         >
>         >
>         > --------------------------------------------------------------------
>         > Joint Stock Company Intel A/O
>         > Registered legal address: Krylatsky Hills Business Park,
>         > 17 Krylatskaya Str., Bldg 4, Moscow 121614,
>         > Russian Federation
>         >
>         > This e-mail and any attachments may contain confidential material for
>         > the sole use of the intended recipient(s). Any review or distribution
>         > by others is strictly prohibited. If you are not the intended
>         > recipient, please contact the sender and delete all copies.
>         >
>         >
>         >
>         > _______________________________________________
>         > LLVM Developers mailing list
>         > llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>
>         > https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_llvm-2Ddev&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=AD-hZ9rLcmVgzhl1TFTAvKbX-nrgHD75y9sqN5zTEsg&s=42V9lvDIvDXSSvzhNIJLw7ddZMt54c2yNRxFpSMppEg&e=
>         >
> 
>         _______________________________________________
>         LLVM Developers mailing list
>         llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>
>         https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_llvm-2Ddev&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=AD-hZ9rLcmVgzhl1TFTAvKbX-nrgHD75y9sqN5zTEsg&s=42V9lvDIvDXSSvzhNIJLw7ddZMt54c2yNRxFpSMppEg&e=
> 
> 
>     _______________________________________________
>     LLVM Developers mailing list
>     llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>
>     https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
> 



More information about the llvm-dev mailing list