[llvm-dev] Adding llvm-undname to the llvm-cov bot
Nico Weber via llvm-dev
llvm-dev at lists.llvm.org
Tue Jun 4 16:41:11 PDT 2019
On Mon, Jun 3, 2019 at 2:06 PM <vsk at apple.com> wrote:
> Hi Nico,
> Sorry for the delay, I've been OOO. The llvm-cov bot should produce
> reports for llvm-undname starting today.
Thanks! It looks like
http://lab.llvm.org:8080/coverage/coverage-reports/index.html now has an
"llvm-undname" entry, but
doesn't have an entry for llvm/lib/MicrosoftDemangle.cpp (and neither does
What I'd ideally want is that the llvm report (
shows coverage data for
in addition to the other files that are there (and there's no separate
report for llvm-undname). I figured what the bot does is run `check-llvm`
and then pass all binaries that run as part of `llvm-check` to the report
generation script, and I had assumed llvm-undname was just missing on that
list of all binaries. But maybe that's not how that coverage list is
> As for +x permissions on llvm/utils/prepare-code-coverage-artifact.py,
> it's an oversight that they are missing. I wasn't able to land a
> permissions change via the new monorepo (I get: "Committed c3b9398d101 to
> svn", but the commit does not appear). Perhaps you'll have better luck?
I couldn't figure out how to do it via git-svn / `git-llvm push` either,
but I added the +x bit in r362561 using an old svn checkout I had lying
> On May 31, 2019, at 8:01 PM, Chris Matthews <chris.matthews at apple.com>
> Probably this job:
> 💬 from 📱
> On May 31, 2019, at 3:35 PM, Duncan Exon Smith <dexonsmith at apple.com>
> +Chris Matthews, do you know where the configs are stored for this?
> On 2019 May 31, at 12:39, Chris Bieneman <beanz at apple.com> wrote:
> Hey Nico,
> I'm actually not sure where the configurations for that bot are stored. I
> suspect Duncan may have a better idea.
> I'm reasonably certain that the missing +x is just an oversight.
> On May 30, 2019, at 6:24 PM, Nico Weber via llvm-dev <
> llvm-dev at lists.llvm.org> wrote:
> Vedant or Chris: Ping :)
> On Wed, May 29, 2019 at 7:56 AM Nico Weber <thakis at chromium.org> wrote:
>> Hi Vedant and Chris,
>> is the config for
>> http://lab.llvm.org:8080/coverage/coverage-reports/index.html public
>> somewhere? If so, where? (I looked in zorg but didn't find it.)
>> If not, could you add "llvm-undname" to the list of binaries passed to
>> llvm/utils/prepare-code-coverage-artifact.py so that
>> llvm/lib/Demangle/MicrosoftDemangle.cpp (and friends) show up? (If the
>> config is public, I can send you a patch.)
>> Also, is there a reason llvm/utils/prepare-code-coverage-artifact.py
>> doesn't have +x set, or is that just an oversight?
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-dev