[llvm-dev] RFC: changing variable naming rules in LLVM codebase

Bakhvalov, Denis via llvm-dev llvm-dev at lists.llvm.org
Mon Jul 22 10:16:07 PDT 2019


I think I agree too.
It's easier to freeze the downstream development once for a couple of days and do all the necessary changes, than to do it in small portions multiple times.
I'm +1 for one big change.

Best regards,
Denis Bakhvalov.

On Jul 18, 2019, at 3:49 PM, Rui Ueyama via llvm-dev <llvm-dev at lists.llvm.org<mailto:llvm-dev at lists.llvm.org>> wrote:

And one more question:
What is the plan of renaming variables in llvm and clang? Will it be done gradually, i.e. directory by directory?

That's a big topic. I was thinking of starting a new thread just for that. Originally I was trying to do this directory-by-directory basis, but now I'm inclined to do this in a single extremely large patch. There's a risk of doing this that way (in particular, I'm not confident that I can keep the buildbots green or will be able to make them green in a timely manner after committing), but I think that will make downstream repo maintainer's work easier.

FWIW, I was originally nervous and slightly opposed to that, but I now agree with you that a big change is probably the right thing to do.

-Chris
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20190722/1ca2081f/attachment-0001.html>


More information about the llvm-dev mailing list