[llvm-dev] Removing LLVM_ALWAYS_INLINE from ADT classes

David Greene via llvm-dev llvm-dev at lists.llvm.org
Thu Jan 17 11:56:14 PST 2019

Nico Weber <thakis at chromium.org> writes:

>     +1. This is exactly the reason I'm nervous about making
>     LLVM_OPTIMIZED_TABLEGEN on by default. As someone who does a fair
>     amount of .td twiddling and also occasionally hacks on TableGen
>     itself, I almost never build it optimized.
> Maybe LLVM_OPTIMIZED_TABLEGEN could do Release+Asserts builds?
> (I don't have any opinion on anything here, just throwing out ideas)

When I'm hacking on TableGen, I frequently run it in a debugger and
anything that degrades that experience is problematic.  Ideally we'd
have better debugging experiences with optimized code but we're not
there yet.

TableGen should probably be reworked to not require asserts enabled to
detect bad input.  That just seems really wrong.  This would allow more
use of LLVM_OPTIMIZED_TABLEGEN but I personally would still want a debug
build to build a debug TableGen for use with a debugger.


More information about the llvm-dev mailing list