[llvm-dev] Removing LLVM_ALWAYS_INLINE from ADT classes

Alex Bradbury via llvm-dev llvm-dev at lists.llvm.org
Wed Jan 16 01:18:36 PST 2019

On Mon, 14 Jan 2019 at 23:11, Nico Weber via llvm-dev
<llvm-dev at lists.llvm.org> wrote:
> I agree that shelling out to `cmake --build` as a build step is pretty ugly.
> It seems kind of simpler to me to just always build Support and TableGen with O3 always, even in debug builds. Most people don't debug code in Support and TableGen, and there could be a disable switch for those that do. That gives you a fast(er) debug build without building any files twice. Is that something CMake can do? If so, is this something that was considered?

As mentioned elsewhere in the thread, building TableGen with
Debug+Asserts isn't only useful for people who want to debug TableGen
itself. It's useful for anybody modifying .td as many checks on .td
input are only run in an asserts build. If there is a desire to move
to LLVM_OPTIMIZED_TABLEGEN by default I think the correct next step is
to write up a separate RFC on this, detailing the advantages,
disadvantages, and potential paths forward. One of the obvious path
forwards is to put development effort into ensuring that tablegen
doesn't need asserts enabled in order to catch invalid inputs.



More information about the llvm-dev mailing list