[llvm-dev] [llvm-rc] absolute.test failing
Martin Storsjö via llvm-dev
llvm-dev at lists.llvm.org
Thu Jan 10 13:10:35 PST 2019
On Thu, 10 Jan 2019, David Greene wrote:
> Martin Storsjö <martin at martin.st> writes:
>> On Wed, 9 Jan 2019, David Greene wrote:
>>> I've come across a curious and pernicious problem in llvm-rc.
>>> absolute.test checks that llvm-rc can accept a filename that is an
>>> absolute path. And it works just fine. Until you run it with a file
>>> that starts with "/c."
>> Hmm, that's rather unfortunate indeed.
>> FWIW, this test doesn't test specifically whether llvm-rc can accept
>> an absolute filename as command line argument - all the llvm-rc tests
>> run llvm-rc with absolute filenames as arguments. This test checks
>> whether llvm-rc can handle an absolute filename reference within a rc
>> I presume you run into the same issue on all other tests in
>> test/tools/llvm-rc as well?
> Actually, I don't. Now I wonder why...
>> One way of disambiguating between option and pathname for the sake of
>> the tests, would be to add '--' before the path arguments, which seems
>> to be handled by the LLVM options parser at least. Does that sound
>> sensible to you (and others CC:d)?
> I tried that and it didn't work. Same error.
> $ ./bin/llvm-rc -- /choose/me
> Exactly one input file should be provided.
Oh, then apparently something extra has to be done to get this behaviour
out of the -- parameter; I only tested that it wasn't rejected. Will have
a look soon.
More information about the llvm-dev