[llvm-dev] RFC: changing variable naming rules in LLVM codebase

[Hubert Tong via llvm-dev]

On Thu, Feb 14, 2019 at 7:32 PM Mehdi AMINI via llvm-dev <
llvm-dev at lists.llvm.org> wrote:

>
>
> On Thu, Feb 7, 2019 at 2:11 PM Michael Platings via llvm-dev <
> llvm-dev at lists.llvm.org> wrote:
>
>> TL;DR: change the rule for variable names from UpperCamelCase to
>> lowerCamelCase.
>>
>>
>> Just to get wider visibility on this, I'm raising this again as an RFC,
>> as suggested by Roman Lebedev.
>>
>>
>> My original post from last week is here and gives a rationale:
>> http://lists.llvm.org/pipermail/llvm-dev/2019-February/129854.html.
>> There seemed to be general agreement that the status quo is not ideal.
>>
>>
>> Chris Lattner pointed out that this came up in 2014 as well:
>> http://lists.llvm.org/pipermail/llvm-dev/2014-October/077685.html
>>
>>
>> I've created a patch to implement the change. Review and comments
>> welcome: https://reviews.llvm.org/D57896
>>
>
>
> I'm concerned about the internal inconsistency we would live with for
> (likely) many years if there is not a migration plan to converge the code
> base toward the new naming convention.
> (other than that, changing the convention is fine with me, I don't have
> much preference here)
>
I think consistency within a function (for locals) and within a class (for
class members) is enough. I don't think that is any worse than the
consistency over
int *p;
versus
int* p;


>
> --
> Mehdi
>
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20190214/0aaf4415/attachment.html>