[llvm-dev] How to submit a change for code review using arc

Don Hinton via llvm-dev llvm-dev at lists.llvm.org
Sat Apr 27 19:10:14 PDT 2019


On Sat, Apr 27, 2019 at 5:53 PM Wink Saville <wink at saville.com> wrote:

> > While it's still fresh in your mind, you might consider updating
> https://llvm.org/docs/Phabricator.html (which is
> llvm/docs/Phabricator.rst) based on your experience,
> > which will make it easier for future contributors.  I guess the main
> issue is getting used to the fact that Phabricator user names are
> independent and must be looked up on the web site -- at least I haven't
> found any other way -- but that isn't spelled out anywhere.
> >
> > thanks again...
> > don
>
> Yes I'll see what I can do to improve the documentation.
>
> Since github seems to be a well known workflow and seems to work OK,
> it would be nice if that could be used. Is anyone working on that?
>
> Is there an RFC or some such on what are the requirements for code
> reviews/pull requests?
>

Not sure if this is what you mean, but here's a current thread you may find
interesting.

https://lists.llvm.org/pipermail/llvm-dev/2019-March/131135.html

hth...
don


>
> -- Wink
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20190427/66983c2b/attachment.html>


More information about the llvm-dev mailing list