[llvm-dev] How to submit a change for code review using arc

Don Hinton via llvm-dev llvm-dev at lists.llvm.org
Sat Apr 27 13:43:09 PDT 2019


Hi Wink:

On Fri, Apr 26, 2019 at 10:53 AM Wink Saville via llvm-dev <
llvm-dev at lists.llvm.org> wrote:

> On Thu, Apr 25, 2019 at 8:32 PM Doerfert, Johannes <jdoerfert at anl.gov>
> wrote:
> >
> > The username has to exist on phabricator:
> > https://reviews.llvm.org/p/peterc/   -> 404
> > https://reviews.llvm.org/p/evgeniys/ -> 404
> >
> > I'm guessing you want:
> > https://reviews.llvm.org/p/daemon/ -> Evgeniy
> > https://reviews.llvm.org/p/pcc/ -> Peter Collingbourne
>
> Thanks, using daemon and pcc worked. I must say the documentation I
> found wasn't helpful, so thanks for the prompt reply!!
>

While it's still fresh in your mind, you might consider updating
https://llvm.org/docs/Phabricator.html (which is llvm/docs/Phabricator.rst)
based on your experience,
which will make it easier for future contributors.  I guess the main issue
is getting used to the fact that Phabricator user names are independent and
must be looked up on the web site -- at least I haven't found any other way
-- but that isn't spelled out anywhere.

thanks again...
don


> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20190427/81746cce/attachment.html>


More information about the llvm-dev mailing list