[llvm-dev] How to submit a change for code review using arc
Wink Saville via llvm-dev
llvm-dev at lists.llvm.org
Thu Apr 25 20:08:22 PDT 2019
I've gone through Code Reviews with Phabriactor, Arcanist Quick
Start and Arcanist User Guide arc diff. But I'm unable to setup
reviewers my editor pops up and there is a "Reviewers:" line and but
I'm unable email addresses directly. It seems it wants reviewers
passed on the command line or some how in .arcconfig.
But I haven't been able to find any documentation on how to setup
reviewers so I've guessed you can add it to .git/arc/config:
What I've got now is my .git/arc/config is:
"peterc": "peter at pcc.me.uk",
"evgeniys": "eugeni.stepanov at gmail.com",
"llvm-commits": "llvm-commits at lists.llvm.org"
My commit message is:
$ git log -1
commit f04a938e5ad72afbf64242718d456fa480ad5f6b (HEAD ->
Author: Wink Saville <wink at saville.com>
Date: Tue Apr 23 16:55:21 2019 -0700
[compiler-rt] Fix cmake warnings
- Fix cmake BOOL misspellings
- Set cmake policy for CMP0075 to NEW
Reviewers: peterc, evgeniys
The result of "arc diff master" is:
$ arc diff master
You have untracked files in this working copy.
Working copy: /home/wink/prgs/llvm/llvm-project/
Commit message has errors:
- Error parsing field "Reviewers": The objects you have listed include
objects which do not exist (peterc, evgeniys).
You must resolve these errors to continue.
Do you want to edit the message? [Y/n] n
Usage Exception: Message has unresolved errors.
More information about the llvm-dev