[llvm-dev] Opt Bisect layering

[via llvm-dev]

It looks like the dependency is really minimal, just an informational query about a Loop/Region/CallGraphSCC and not on any actual analysis.  Seems like there should be a pattern that would make that reasonable while maintaining the layering.  Maybe a minimalist IRAggregate class that supports what OptBisect needs and becomes a base for the others?  (Don't you love people who do drive-by hand-waving?)
--paulr

From: llvm-dev [mailto:llvm-dev-bounces at lists.llvm.org] On Behalf Of David Blaikie via llvm-dev
Sent: Wednesday, March 21, 2018 12:09 PM
To: llvm-dev; Kaylor, Andrew; Friedman, Eli
Subject: [llvm-dev] Opt Bisect layering

So I'm poking around trying to improve the layering of LLVM (using an internal strict modular build as a motivation/tool to identify issues) & came across a layering violation in the OptBisect implementation.

This feature is implemented in lib/IR, but includes several headers from include/llvm/Analysis - which would create a circular dependency if not for the fact that all the headers it includes are header-only (templates).

Any ideas about how this could/should be fixed? Perhaps these analyses should be moved into somewhere more common - but I don't know there's anywhere more (or less) common than lib/IR itself (since I assume they depend on IR & that's where OptBisect is, so they can't be lower/higher than that).

Does that sound OK? Anyone have other/better ideas?

- Dave
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20180321/f918f831/attachment.html>