[llvm-dev] [LLD] Lack of REQUIRES causing test failures when not building with x86 support
llvm-dev at lists.llvm.org
Tue Jun 5 08:52:50 PDT 2018
There are some already, I have been caught out by that before on compiler changes; maybe one could have LLD added to their list of projects.
From: llvm-dev [mailto:llvm-dev-bounces at lists.llvm.org] On Behalf Of Rui Ueyama via llvm-dev
Sent: Tuesday, June 05, 2018 11:48 AM
To: Peter Smith
Cc: llvm-dev; joelkevinjones at gmail.com
Subject: Re: [llvm-dev] [LLD] Lack of REQUIRES causing test failures when not building with x86 support
In order to catch a missing "REQUIRES: x86", it might be a good idea to set up a build bot without the x86 support.
On Mon, Jun 4, 2018 at 8:53 AM Peter Smith via llvm-dev <llvm-dev at lists.llvm.org<mailto:llvm-dev at lists.llvm.org>> wrote:
I don't think that there is a cunning plan with REQUIRES. I seem to
remember that there was some debate over the testing strategy and
platforms, but unfortunately I can't quickly find a link to it. In
- Much of the functionality of LLD is target independent, for example
linker script support.
- To write a test needs us to pick a target for these types of test
and X86 was chosen as this was the most likely target to be compiled
into build machines, for example the Arm and AArch64 buildbots include
the X86 backend.
I think that the missing 117 "REQUIRES" are an oversight, or
historical artefact, and I think patches would be welcome to add them
back in; a bot that doesn't build in the X86 backend is probably
needed to keep this maintained as it is easy to forget the REQUIRES.
However I think that if the goal is to test the majority of the
functionality of LLD it would be wise to compile in support for X86 as
much of the generic functionality will go untested.
On 4 June 2018 at 15:49, Joel Jones via llvm-dev
<llvm-dev at lists.llvm.org<mailto:llvm-dev at lists.llvm.org>> wrote:
> If I build lld without x86 support (i.e. with "cmake -DLLVM_TARGETS_TO_BUILD=AArch64”) there are 117 tests that fail “make check-lld”. Upon examination, all are x86 related.
> There are multiple (884) tests that have “REQUIRES:.*x86” in the tests directory. Was there a cunning plan regarding the use of REQUIRES that I couldn’t discern?
> It seems that either 117 “REQUIRES” need to be added or 884 need to be removed.
> Joel Jones
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org<mailto:llvm-dev at lists.llvm.org>
LLVM Developers mailing list
llvm-dev at lists.llvm.org<mailto:llvm-dev at lists.llvm.org>
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-dev