[llvm-dev] Submitting patches for LLVM -- llvm-commits vs. Phabricator?
Adrian Prantl via llvm-dev
llvm-dev at lists.llvm.org
Wed Jan 3 09:40:36 PST 2018
> On Jan 2, 2018, at 11:31 AM, Christoph Kindl via llvm-dev <llvm-dev at lists.llvm.org> wrote:
>> Date: Sat, 30 Dec 2017 09:59:56 -0600
>> From: Krzysztof Parzyszek via llvm-dev <llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>>
>> To: llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>
>> Subject: Re: [llvm-dev] Submitting patches for LLVM -- llvm-commits
>> vs. Phabricator?
>> The current practice is to upload a patch to phabricator and add
>> llvm-commits as a subscriber. This will send an email to the mailing
>> list. You can (and should) add some reviewers too.
>> On 31 Dec 2017, at 04:49, Shoaib Meenai wrote:
>> Yup, Phabricator is generally preferred for patches.
>> Additionally, are you subscribed to the mailing list? I can't find where I read it now, but I believe your messages are held for moderation if you aren't subscribed. You can subscribe at http://lists.llvm.org/mailman/listinfo/llvm-commits <http://lists.llvm.org/mailman/listinfo/llvm-commits> if needed.
> Thanks guys! This is my first attempt to submit a patch; I've sent it to llvm-commits because the Developer Guide mentions this as preferred method:
>> Once your patch is ready, submit it by emailing it to the appropriate project’s commit mailing list (or commit it directly if applicable). Alternatively, some patches get sent to the project’s development list or component of the LLVM bug tracker, but the commit list is the primary place for reviews and should generally be preferred.
> I guess this part should be updated then to mention Phabricator as the primary place for submitting and reviewing patches?
Would you mind updating the section and uploading the patch to reviews.llvm.org :-) ?
> I'm subscribed to llvm-commits yes (in digest mode if that should make a difference), but the message was not submitted to the list (it seems to be still in the queue waiting for moderator approval). Anyhow, I will submit my little patch via Phabricator then and refer to the Phabricator docs for procedere and finding reviewers. Thanks!
>> From: llvm-dev <llvm-dev-bounces at lists.llvm.org <mailto:llvm-dev-bounces at lists.llvm.org>> on behalf of Christoph Kindl via llvm-dev <llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>>
>> Reply-To: Christoph Kindl <mail at ckristo.net <mailto:mail at ckristo.net>>
>> Date: Saturday, December 30, 2017 at 7:22 PM
>> To: "llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>" <llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>>
>> Subject: [llvm-dev] Submitting patches for LLVM -- llvm-commits vs. Phabricator?
>> I've recently submitted a patch to llvm-commits (as requested byhttps://llvm.org/docs/DeveloperPolicy.html#making-and-submitting-a-patch <https://llvm.org/docs/DeveloperPolicy.html#making-and-submitting-a-patch>) and the mailing list answered with a notice that my message is held for moderator approval (with the reason: "Post by non-member to a members-only list"). I'm therefore wondering if I should've submitted my patch via Phabricator instead (looking at the activity in llvm-commits, it seems that most of the patches are submitted and reviewed by Phabricator).
>> Best regards,
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-dev