[llvm-dev] https://reviews.llvm.org/D41659 Needs review.
Alex Bradbury via llvm-dev
llvm-dev at lists.llvm.org
Tue Jan 2 02:44:46 PST 2018
On 2 January 2018 at 08:56, ADIL ARUN DANGUI via llvm-dev
<llvm-dev at lists.llvm.org> wrote:
> Implemented missing trigonometric optimization in llvm.
> Here we have implemented the following missing trigonometric optimizations.
> sin(x)*cos(x) = sin(2*x)/2
Hi Adil - welcome to the LLVM community!
The documentation on submitting a patch via Phabricator has some tips
on finding code reviewers:
Looking in CODE_OWNERS.txt I can see that David Majnemer is code owner
for InstCombine, so he should at least be added as a reviewer. Looking
at commits to InstructionCombining.cpp it looks like Craig Topper may
be another appropriate reviewer.
Unless the patch is particularly controversial (this requiring an RFC
or wider community feedback), you're best to add llvm-commits and
reviewers following the above guidance, then wait for a week or so. If
you're not getting any response after a couple of pings then it may be
worth bringing it to the mailing list. I also try to highlight patches
that are either stuck awaiting review or from first time contributors
in the "Review Corner" section of LLVM Weekly. More info and a
submission form here: http://llvmweekly.org/reviewcorner
I hope that helps,
More information about the llvm-dev