[llvm-dev] No longer able to run lit tests within a sub-tool
Zachary Turner via llvm-dev
llvm-dev at lists.llvm.org
Fri Sep 22 11:42:53 PDT 2017
Yea at first I was worried that maybe I changed the semantics of how it
looked in PATH, and you had clang-func-mapping in your PATH somewhere
before but now lit was building a different PATH. But I looked at that
change and it wasn't even creating that substitution before. So it looks
like that CL is indeed the problem.
On Fri, Sep 22, 2017 at 11:38 AM Vedant Kumar <vsk at apple.com> wrote:
> > On Sep 22, 2017, at 11:36 AM, Vedant Kumar <vsk at apple.com> wrote:
> > Ah, the problem goes away once I build clang-func-mapping.
> > I stripped some stuff out, but here's pretty much what clang/test/
> lit.cfg.py says my PATH is:
> > ** PATH **:
> > I wonder how this ever worked before, when I didn't have
> clang-func-mapping built.
> Oh, this might be an issue with r313975, which I picked up when rebasing
> things this morning.
> > Anyway, thanks for your help!
> > vedant
> >> On Sep 22, 2017, at 11:31 AM, Zachary Turner <zturner at google.com>
> >> This works for me. Can you run "which clang-func-mapping" and also add
> a line to clang/test/lit.cfg.py to print the value of
> >> On Fri, Sep 22, 2017 at 11:27 AM Zachary Turner <zturner at google.com>
> >> Looking, thanks for the report.
> >> On Fri, Sep 22, 2017 at 11:22 AM Vedant Kumar <vsk at apple.com> wrote:
> >> As of r313998, this workflow no longer works:
> >> cd <build-dir>
> >> ./bin/llvm-lit <src>/llvm/tools/clang/test/CoverageMapping
> >> I get:
> >> llvm-lit: /Users/vk/src/llvm.org-coverage-braces/llvm/tools/clang/test/
> lit.cfg.py:97: note: using clang:
> >> llvm-lit:
> fatal: unable to parse config file
> traceback: Traceback (most recent call last):
> >> File
> line 88, in load_from_path
> >> exec(compile(data, path, 'exec'), cfg_globals, None)
> >> File "/Users/vk/src/llvm.org-coverage-braces/llvm/tools/clang/test/
> lit.cfg.py", line 128, in <module>
> >> config.substitutions.append( ('%clang_func_map', ' ' +
> lit.util.which('clang-func-mapping', config.environment['PATH']) + ' ') )
> >> TypeError: cannot concatenate 'str' and 'NoneType' objects
> >> However, this still works when running tests within llvm:
> >> ./bin/llvm-lit <src>/llvm/test/tools/llvm-cov
> >> I'd appreciate any help in getting this working again.
> >> thanks,
> >> vedant
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-dev