[llvm-dev] Phabricator "buildable" indication
Lang Hames via llvm-dev
llvm-dev at lists.llvm.org
Thu Nov 9 11:41:47 PST 2017
I just posted a review with arcanist (which I'm fairly new to) and it
included a build status. How it got there is totally opaque to me, but my
workflow was: Using git+svn (following the setup in
make a change, commit with 'git commit', create review with 'air diff'.
It would be cool if arcanist was running some sort of pre-review checks,
but I'm executing arc from my source directory and I'm not sure how it
would be getting from there to the build directory to actually verify
anything about the build.
On Thu, Nov 9, 2017 at 6:16 AM, Nemanja Ivanovic via llvm-dev <
llvm-dev at lists.llvm.org> wrote:
> I am actually curious about that as well. I took it to mean that some
> people have some kind of pre-delivery buildbot hooks in Phabricator. But
> that may just be wishful thinking :).
> On Wed, Nov 8, 2017 at 11:16 PM, Robinson, Paul via llvm-dev <
> llvm-dev at lists.llvm.org> wrote:
>> I've noticed that some reviews, but not others, show up in Phab
>> with a "buildable" indication in a "Diff Detail" box, just below
>> the summary.
>> Can somebody describe what that's about? Most interesting might
>> be why it's there only sometimes, also what sort of "build" this
>> indication is reporting.
>> LLVM Developers mailing list
>> llvm-dev at lists.llvm.org
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-dev