[llvm-dev] Critical XRay fixes for Arm32
Serge Rogatch via llvm-dev
llvm-dev at lists.llvm.org
Thu Jan 26 10:29:32 PST 2017
Hans, these changes reached trunk in https://reviews.llvm.org/rL292516 and
https://reviews.llvm.org/rL292517 . Could you look?
On 26 January 2017 at 03:29, Serge Rogatch <serge.rogatch at gmail.com> wrote:
> Sorry, I initially included LLVM-Commits rather than LLVM-Dev. Fixed.
> On 26 January 2017 at 03:26, Serge Rogatch <serge.rogatch at gmail.com>
>> Hi Dean, Renato,
>> AFAIK, unfortunately, these critical Arm32 XRay fixes are not yet in 4.0:
>> https://reviews.llvm.org/D28624 , https://reviews.llvm.org/D28623 . The
>> first repairs XRay instrumentation map emission. Without this map XRay
>> doesn't work at all: the runtime doesn't see anything to instrument. The
>> second fixes the CPU cache incoherency problem. Without this patch, XRay
>> will intermittently fail to patch or unpatch some sleds (depending on
>> whether their code is in CPU cache or not).
>> Is there any chance we can get these patches to 4.0? This page
>> http://llvm.org/docs/HowToReleaseLLVM.html#release-patch-rules says that
>> "release manager, the official release testers or the code owners" may
>> approve cherry-picking to release branch from trunk. AFAIK, you are code
>> owners for XRay and ARM. I don't know who are the release manager or
>> official release testers.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-dev