[llvm-dev] Removed a call to EmitXRayTable() from ARMAsmPrinter

Oleg Ranevskyy via llvm-dev llvm-dev at lists.llvm.org
Mon Jan 9 13:32:25 PST 2017

Hi Renato,

As far as I understand, such issues should be caught by the tests in compiler-rt/test/xray/TestCases/Linux.
I found the following lines in compiler-rt/test/xray/lit.cfg that seem to disable the tests for non-64-bit targets:

if config.host_os not in ['Linux'] or config.host_arch.find('64') == -1:
  config.unsupported = True

@Serge: You will need to change this condition to enable the tests for ARM.


From: Renato Golin <renato.golin at linaro.org>
Sent: Monday, January 9, 2017 11:50 PM
To: Serge Rogatch
Cc: Dean Michael Berris; LLVM Developers; Oleg Ranevskyy
Subject: Re: [llvm-dev] Removed a call to EmitXRayTable() from ARMAsmPrinter

On 9 January 2017 at 20:47, Serge Rogatch via llvm-dev
<llvm-dev at lists.llvm.org> wrote:
>> Without this call, xray_instr_map gets empty in the executable, so that
>> XRay doesn't patch anything. While implementing the tail call handling, I am
>> reverting this change (I mean, just returning the call to emitXRayTable()
>> where it was), or are there reasons I shouldn't?

Any reason why no tests were harmed in the process? Maybe we're not
testing as thorough as we thought?


More information about the llvm-dev mailing list