[llvm-dev] Removed a call to EmitXRayTable() from ARMAsmPrinter

Serge Rogatch via llvm-dev llvm-dev at lists.llvm.org
Mon Jan 9 12:47:00 PST 2017


Sharing with the mailing list... Please, see below.

On 9 January 2017 at 23:45, Serge Rogatch <serge.rogatch at gmail.com> wrote:

> Hi Dean,
>
> I have seen that you removed the following code from ARMAsmPrinter.cpp in
> revision 290858:
>   // Emit the XRay table for this function.
>   EmitXRayTable();
>
> Was this done by mistake or on purpose?
>
> Without this call, xray_instr_map gets empty in the executable, so that
> XRay doesn't patch anything. While implementing the tail call handling, I
> am reverting this change (I mean, just returning the call to
> emitXRayTable() where it was), or are there reasons I shouldn't?
>
> Cheers,
> Serge
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20170109/f4460f40/attachment.html>


More information about the llvm-dev mailing list