[llvm-dev] RFC: Reconsidering adding gmock to LLVM's unittest utilities

Robinson, Paul via llvm-dev llvm-dev at lists.llvm.org
Fri Jan 6 09:28:32 PST 2017


> b) We will definitely want some guidelines around *how* and *when* to
> use this stuff. I'll try and distill something more brief than my email
> and incorporating some of the comments on this thread, and put it up
> for review as an addition to the coding standards. This will take me a
> bit more time but I'm happy to make sure this happens. This code review
> can then serve as a place to discuss the somewhat mechanical bits that
> are still important such as should we write `EXPECT_EQ(b, a)`,
> `EXPECT_THAT(a, Eq(b))`, or (with some custom magic) `EXPECT(a, Eq(b))`.

Let me suggest that guidelines specific to test code ought to be
separated from the main coding standard, and probably on their own 
webpage.  This would help focus the new stuff and avoid cluttering
the existing stuff.
Thanks,
--paulr



More information about the llvm-dev mailing list