[llvm-dev] RFC: Exposing TargetTransformInfo factories from TargetMachine

Eric Christopher via llvm-dev llvm-dev at lists.llvm.org
Mon Dec 18 18:26:10 PST 2017


Instead, is there any reason why TTI for a given Subtarget shouldn't live
on the Subtarget? Just construct it the same way we do TargetLowering, etc?

-eric

On Fri, Dec 15, 2017 at 10:13 AM Sanjoy Das via llvm-dev <
llvm-dev at lists.llvm.org> wrote:

> On Fri, Dec 15, 2017 at 5:30 AM, Hal Finkel <hfinkel at anl.gov> wrote:
> > Are there reasons why we might not want to do this? Other options we
> should
> > consider?
>
> It does make the TargetMachine -> TargetIRAnalysis path less abstract,
> but given that all targets have the same pattern of instantiating a
> TargetIRAnalysis with a Function->TargetTransformInfo hook, the
> abstraction does not seem particularly useful.
>
> I might do even a simpler form of the patch though -- instead of
> returning a function pointer from TargetMachine, just add a virtual
> function to TargetMachine that creates the TargetTransformInfo
> directly from a Function.
>
> -- Sanjoy
>
> >
> >  -Hal
> >
> >>
> >> [0]:  XLA is a machine learning focussed linear algebra compiler
> >> https://www.tensorflow.org/performance/xla/ that uses LLVM for its CPU
> >> and GPU backends.
> >>
> >> -- Sanjoy
> >> _______________________________________________
> >> LLVM Developers mailing list
> >> llvm-dev at lists.llvm.org
> >> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
> >
> >
> > --
> > Hal Finkel
> > Lead, Compiler Technology and Programming Languages
> > Leadership Computing Facility
> > Argonne National Laboratory
> >
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20171219/777ad99d/attachment.html>


More information about the llvm-dev mailing list