[llvm-dev] [RFC] Require PRs for XFAILing tests

David Chisnall via llvm-dev llvm-dev at lists.llvm.org
Fri Sep 30 02:41:31 PDT 2016

On 29 Sep 2016, at 18:42, Chris Bieneman via llvm-dev <llvm-dev at lists.llvm.org> wrote:
> Requiring comments for XFAIL is much harder to enforce via tools, and would need to be enforced with code review. One advantage I see to this process is that the tooling support is a relatively simple patch to LIT.

It would be easy to enforce by changing the syntax of XFAIL to XFAIL <msg> and having lit report an error if tests didn’t contain a message for the XFAIL.  lit -v could also then report the reasons for the XFAILing tests.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 3719 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20160930/689e5eae/attachment.bin>

More information about the llvm-dev mailing list