Mehdi Amini via llvm-dev
llvm-dev at lists.llvm.org
Mon Nov 21 10:16:18 PST 2016
> On Nov 21, 2016, at 10:14 AM, Reid Kleckner <rnk at google.com> wrote:
> On Sat, Nov 19, 2016 at 12:44 PM, Simone Atzeni via llvm-dev <llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>> wrote:
> Thanks Mehdi.
> My pass clones the functions within a module in order to have the original function and an exact copy of the same function but with a different name, i.e. sum() and sum_parallel().
> After my pass I will run ThreadSanitizer instrumentation pass only on the new copy of the functions, i.e. only the “_parallel” functions will be instrumented by tsan.
> In some programs that I am compiling, the functions such as atoi and atof get cloned but I want to avoid this, and I noticed that only those functions have GlobalValue::AvailableExternallyLinkage, so I was wondering if checking the linkage is enough to avoid those library functions or there could be situations of functions with that linkage but that have the body implemented in the same module.
> Checking for this linkage should be enough. If a function has available_externally linkage, then some other module *must* provide an equivalent, strong definition of that function, so you shouldn't need (or want) to clone such functions.
I disagree: depending on your use case you may want to instrument all the user code of an application. Any available_externally function may be inlined in the current module, in a non-instrumented form. The fact that it will be instrumented in the original module is not enough.
> The root of your problem is that you clone "atoi" into "atoi_parallel", but you leave the linkage as available_externally, which means that you are also promising that some other module out there provides the symbol "atoi_parallel". Obviously, that isn't the case, so you get linker errors.
> You could also resolve your problem by giving the parallel clones 'internal' linkage.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-dev