[llvm-dev] Highlighting trailing whitespaces on Phab?
Rui Ueyama via llvm-dev
llvm-dev at lists.llvm.org
Mon Nov 14 14:52:43 PST 2016
On Mon, Nov 14, 2016 at 2:49 PM, Mehdi Amini <mehdi.amini at apple.com> wrote:
> I see! That’d be nice to have indeed.
> Ideally I’d even really like to have a both checking for revision on phab,
> clang-formatting them, and post a comment when there is a mismatch :)
... as bot comments. Yeah, that would be very useful.
> On Nov 14, 2016, at 2:43 PM, Rui Ueyama <ruiu at google.com> wrote:
> When I create a patch, I run clang-format-diff, so that's fine. What I
> want to do is to find trailing whitespaces in others patches.
> On Mon, Nov 14, 2016 at 2:30 PM, Mehdi Amini <mehdi.amini at apple.com>
>> clang-format removes them.
>> If you are (like me) likely to forget to run "git clang-format HEAD~”
>> before pushing, adding a pre-commit (or pre-push) hook is helpful.
>> > On Nov 14, 2016, at 2:01 PM, Rui Ueyama via llvm-dev <
>> llvm-dev at lists.llvm.org> wrote:
>> > I wonder if Phabricator has an ability to highlight trailing
>> whitespaces, because I often find trailing whitespaces after they are
>> submitted. If they were highlighted, they would have been removed before
>> submitting. Does anyone know about this?
>> > _______________________________________________
>> > LLVM Developers mailing list
>> > llvm-dev at lists.llvm.org
>> > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-dev