[llvm-dev] [RFC] Helping release management
Mehdi Amini via llvm-dev
llvm-dev at lists.llvm.org
Tue May 17 12:41:13 PDT 2016
> On May 17, 2016, at 12:40 PM, Mehdi Amini via llvm-dev <llvm-dev at lists.llvm.org> wrote:
>> On May 17, 2016, at 12:30 PM, Renato Golin via llvm-dev <llvm-dev at lists.llvm.org> wrote:
>> On 17 May 2016 at 20:04, Justin Bogner via llvm-dev
>> <llvm-dev at lists.llvm.org> wrote:
>>>> Note that this would also fire when a commit referring to a PR gets
>>>> reverted (assuming the reverting commit doesn't botch the commit
>>>> message), etc., which is super useful for those following along on the
>>>> bug's cc list.
>>> +1. This would be a very useful thing to have, regardless of where the
>>> rest of this thread goes.
>> I like this idea, too. But wouldn't this only work if the PR was in the title?
> I don't see why?
> The notion of title is already just a convention, any tool that look at the title has to filter it out of the full commit message in the first place AFAIK.
> So I don't see any obstacle to have a regex that would match any part of the commit message.
i.e.: it is not different from what Phabricator does when it "automatically" close a revision when it sees the "Differential Revision: ... " line in the message.
More information about the llvm-dev