[llvm-dev] CMake version specific tweaks in compiler-rt
Chris Bieneman via llvm-dev
llvm-dev at lists.llvm.org
Fri Jun 3 10:58:22 PDT 2016
I deliberately left that code in place so that if we needed to revert the patch was small. At this point I don’t think there is any reason not to start the cleanup process. I was planning to start looking into some of the cleanup early next week.
So far there has only been one issue that I’m aware of, which David Li put in a workaround for (compiler-rt - r271582). If anyone is aware of any other problems as a result of the CMake bump please let me know ASAP, but I don’t expect any issues warranting a revert would appear this late.
> On Jun 3, 2016, at 10:05 AM, Eugene Zelenko via llvm-dev <llvm-dev at lists.llvm.org> wrote:
> I'm not CMake expert :-( Will be good idea if people with more
> knowledge will clean up.
> On Fri, Jun 3, 2016 at 8:38 AM, Reid Kleckner <rnk at google.com> wrote:
>> Yeah, if you want to send cleanup patches, we can definitely stamp them.
>> On Thu, Jun 2, 2016 at 11:54 AM, Eugene Zelenko via llvm-dev
>> <llvm-dev at lists.llvm.org> wrote:
>>> compiler-rt's CMakeLists.txt still contains tweaks for CMake version
>>> 2.8. Pre-2.8.12 are definitely irrelevant for CMake 3.4.3, but may be
>>> post-2.8.12 tweaks are irrelevant too?
>>> LLVM Developers mailing list
>>> llvm-dev at lists.llvm.org
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
More information about the llvm-dev