[llvm-dev] Target Acceptance Policy
Andrey Bokhanko via llvm-dev
llvm-dev at lists.llvm.org
Fri Jul 29 06:34:23 PDT 2016
I'm not speaking on ways to circumvent the review system, but rather on
when enough is enough.
Do you expect whole back-ends to receive the same level of code review as
individual incremental patches to existing ones? If yes, by who? In case of
existing back-ends, there are maintainers who understand the code and able
to do a proper code review; who can do the same for new back-ends?
Can we put some formal expectations into your guidelines?
On Fri, Jul 29, 2016 at 3:38 PM, Renato Golin <renato.golin at linaro.org>
> On 29 July 2016 at 12:09, Andrey Bokhanko <andreybokhanko at gmail.com>
> > What if a new back-end ticks all the right boxes but simply not being
> > reviewed by established members of the community?
> This case is clear. The code only goes in after proper review.
> Interests vary from case to case, and normally, pinging on the mailing
> list and on IRC is the only way to go. Waiting forever doesn't work,
> and asking a friend maintainer to "push it for you" or just pushing
> yourself is very much *never* appropriate.
> This is one of the few clear cases I can think of that would warrant a
> permanent commit ban for all involved.
> Upstream takes time, we all have to live with it. But the alternative
> is worse. :)
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-dev