[llvm-dev] [RFC] One or many git repositories?
Renato Golin via llvm-dev
llvm-dev at lists.llvm.org
Mon Jul 25 04:09:14 PDT 2016
On 25 July 2016 at 11:59, David Chisnall via llvm-dev
<llvm-dev at lists.llvm.org> wrote:
> How difficult would it be with GitHub to set up something to automatically merge pull requests if they keep the buildbots happy?
It's not just about passing the tests...
Currently, post-commit review committers have the ability to commit in
areas where they are comfortable with or they own, not the entire
project. The whole area is very fuzzy, and there's no automated way of
doing that at the moment.
A pull request is a request for *comment*, and we currently express
that via a Phab review. If I'm comfortable with the patch, I commit
directly, if I want others opinions, I create a review. If we move as
you propose, I'd lose the second option.
I also don't think pre-commit review committers should be just relying
on the fast bots passing. There are many other issues like code
quality, formatting, tests, etc. that need to be done properly.
If we go this route, we'll be effectively flattening out everyone that
has commit access into one big pool, and that would be a massive
change in how our community operates (for better or worse).
Unless you're also proposing that only the "core team" (code owners,
high committers, etc) get commit access in the new style.
> The workflow would be exactly the same for committers and non-committers, except that committers would be able to tag their own pull requests as ready to merge.
Can this be controlled via a server hook? One that would be supported by GitHub?
More information about the llvm-dev