[llvm-dev] Diff to add ARMv6L to Target parser

[Eric Christopher via llvm-dev]

The swift repository is old and many thousand revisions behind llvm. Please
don't use it as a base when submitting to the llvm project.

On Thu, Jan 7, 2016, 10:02 AM William Dillon <william at housedillon.com>
wrote:

> Oops, I neglected to reply-all….
>
> The current stable branch at github still has it:
>
>
> https://github.com/apple/swift-llvm/blob/stable/include/llvm/Support/ARMTargetParser.def#L106
>
> Should I get the head of the non-swift repository and generate a new diff?
>
> Also, I suspect that it’s not a good idea to have armv6l map to armv6k,
> because that seems like quite an assumption to make.  Clearly, armv6 sub
> architectures that aren’t v6k will still be v6l in linux. (provided they’re
> little-endian).
> I’ve already made that change, and it would be included in any revised
> diff that I send out.
>
> Thanks,
> - Will
>
> On Jan 6, 2016, at 10:02 AM, Artyom Skrobov <Artyom.Skrobov at arm.com>
> wrote:
>
> William, what revision of LLVM is your patch based on?
>
> The trunk hasn't had ARM_ARCH("armv6hl") since r252903 (Nov 12th)
>
>
> -----Original Message-----
> From: William Dillon [mailto:william at housedillon.com
> <william at housedillon.com>]
> Sent: 06 January 2016 17:55
> To: Renato Golin
> Cc: Tim Northover; LLVM Dev; nd; Artyom Skrobov; Daniel Sanders; Eric
> Christopher
> Subject: Re: [llvm-dev] Diff to add ARMv6L to Target parser
>
> Taking the suggestions of the group under consideration, I’ve generated a
> new diff.  The thing to note is that armv6l is now treated identically to
> armv6hl.  I’ve also added a unit test.
> This seems to me to be the least invasive method, and holds to existing
> conventions as closely as possible.
>
> Thoughts?
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20160107/bb33e91e/attachment.html>