[llvm-dev] visitShiftByConstant of DAGCombiner

[Jojo Ma via llvm-dev]

Hi Renato,

There will be two more check fail one after another(below), after fix this
one.
But we could remove the check lines in my opinion, as the check fails are
caused by
different instructions sequence after  canonicalisation. And the
canonicalisation
won't
affect the LICM.

   -

/home/likewise-open/SPREADTRUM/
jojo.ma/jojoma/source/llvm/llvm-linaro/llvm/llvm/test/CodeGen/Thumb2/machine-licm.ll:91:10:
error: expected string not found in input
; CHECK: movw {{(r[0-9]+)|(lr)}}, #65534
         ^
<stdin>:59:2: note: scanning from here
 movt r12, #65535
 ^

   -

/home/likewise-open/SPREADTRUM/
jojo.ma/jojoma/source/llvm/llvm-linaro/llvm/llvm/test/CodeGen/Thumb2/machine-licm.ll:99:10:
error: expected string not found in input
; CHECK: and
         ^
<stdin>:67:2: note: scanning from here
 uxtb r3, r2
 ^
<stdin>:82:3: note: possible intended match here
 .indirect_symbol _GV
  ^

The diff was updated:
https://reviews.llvm.org/D27916

Welcome all your comments!Thank you very much!

Best Regards,
Jojo

On 20 December 2016 at 00:30, Renato Golin <renato.golin at linaro.org> wrote:

> On 19 December 2016 at 09:58, Jojo Ma <jojo.ma at linaro.org> wrote:
> > /home/likewise-open/SPREADTRUM/jojo.ma/jojoma/
> source/llvm/llvm-linaro/llvm/llvm/test/CodeGen/Thumb2/
> machine-licm.ll:88:10:
> > error: expected string not found in input
> > ; CHECK: movw {{(r[0-9])|(lr)}}, #32768
> >          ^
> > <stdin>:56:2: note: scanning from here
> >  movw r12, #32768
> >  ^
>
> Hi Jojo,
>
> This is just a bad check line. :)
>
> Instead of:
>
> ; CHECK: movw {{(r[0-9])|(lr)}}, #32768
>
> it should have been:
>
> ; CHECK: movw {{(r[0-9]+)|(lr)}}, #32768
>
> (ie. add the extra '+' at the end, so you allow more than one number).
>
> If that's the last remaining problem, I suggest you fix the CHECK
> line, create the tests necessary to test your pass, and make sure that
> the LICM code makes sense (it doesn't look worse to me, but the
> instructions are different, just need to make sure they have the same
> semantics).
>
> cheers,
> --renato
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20161221/629291ce/attachment.html>