[llvm-dev] help please: how to sort the contents of a "SymbolTableListTraits<GlobalVariable>"?
Mehdi Amini via llvm-dev
llvm-dev at lists.llvm.org
Thu Aug 4 12:45:27 PDT 2016
> On Aug 4, 2016, at 11:52 AM, Daniel Berlin via llvm-dev <llvm-dev at lists.llvm.org> wrote:
> On Thu, Aug 4, 2016 at 11:41 AM, Abe Skolnik via llvm-dev <llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>> wrote:
> On 08/04/2016 01:33 PM, David Majnemer wrote:
> You should never be copying or moving around Values.
> Why not? Is that because of this thing you also wrote in the same message: "use lists are allocated before the object"?
> Among other things.
> They are simply not currently built to be relocated.
> attempts to do so will likely result in a huge mess.
> my strong recommendation here would be to stop trying to go down this path, and instead, if you want a sorted list, just put them in a separate container and sort them.
The thing is that a “SymbolTable” is a “iplist” (it inherit from it) and, iplist has a “sort()” method, it is not clear why we can’t sort then?
The fact that SymbolTable implementation is breaking one of its public method does not seem right to me.
Also, in general, the design assuming any instance of a SymbolTable<GlobalVariabl> is owned by a Module and inspecting the “parent” using magic trick, seems … broken.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-dev