[llvm-dev] [llvm] r250383 - Speculatively unbreak Windows build

JF Bastien via llvm-dev llvm-dev at lists.llvm.org
Fri Oct 16 21:59:39 PDT 2015

Can you instead always proxy-include windows.h? Force all LLVM inclusions
of windows.h to go through lib/Support/Windows/WindowsSupport.h (move it to
include/ instead) and add NOMINMAX. It already has WIN32_LEAN_AND_MEAN, you
could even pile on with VC_EXTRALEAN.

On Fri, Oct 16, 2015 at 4:15 PM, Reid Kleckner via llvm-dev <
llvm-dev at lists.llvm.org> wrote:

> On Fri, Oct 16, 2015 at 2:55 PM, David Blaikie via llvm-dev <
> llvm-dev at lists.llvm.org> wrote:
>> Ah, I see this was addressed in 250386 - though might be nice to address
>> across the whole project rather than this particular inclusion. Though
>> maybe we've few enough inclusions that it's not too bad.
> I'd rather not have an extra flag to every compilation just to handle the
> odd inclusion of windows.h. Most of LLVM should not be including
> system-specific headers, and the parts that do should be small.
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20151016/af1c87ba/attachment.html>

More information about the llvm-dev mailing list