[LLVMdev] LLD: representation of a power of two value
shankare at codeaurora.org
Thu Mar 26 09:23:43 PDT 2015
I was expecting that you would send the patches for review prior
committing the patch.
We could follow this style for all future commits that things get
reviewed before committing, so that its easier to follow a uniform policy.
For example you added a PowerOf2 class in DefinedAtom, for a simple
reason that the class usage went away :) I thought it would also have
helped if you made few commits to cleanup, which IMO would be easier to
review and get a overall sense of the code.
On 3/25/2015 9:30 PM, Rui Ueyama wrote:
> I submitted a series of patches to convert all uses of log2 values to
> non-log2 values (That was harder than I thought because the types of the
> two are the same. They only different in meaning. So it was not easy to
> distinguish them. I split up patches so that anyone can verify correctness
> of the conversion that I've done.)
> >From now on, please always use non-log2 alignment values exclusively in
> LLD. Thanks!
> On Wed, Mar 25, 2015 at 12:16 PM, Sean Silva <chisophugis at gmail.com> wrote:
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by the Linux Foundation
More information about the llvm-dev