[LLVMdev] [cfe-dev] Bikeshedding commit message policy - Round 3 - Fight!

Chris Lattner clattner at apple.com
Sun Mar 15 13:22:38 PDT 2015


> On Mar 15, 2015, at 11:49 AM, Renato Golin <renato.golin at linaro.org> wrote:
> 
> On 15 March 2015 at 16:31, Hal Finkel <hfinkel at anl.gov> wrote:
>> I don't want to code when to use them. But it makes sense to say, "If you want to include a title tag, do it like this...".
> 
> I'm ok with that.
> 
> So, do we have consensus?
> 
> 1. Don't require, but recommend using [] for tags.
> 
> 2. Don't specify attribution more than just "patch by Foo." and expect
> people to be sensible. Current scripts already work with a good
> variation anyway.

Can you post the entire revised diff that you want to include?  Is it Diff 21913 on Phab?  If so, LGTM.

-Chris



More information about the llvm-dev mailing list