[LLVMdev] RFC: Dropping support for building sanitizers with autotools

[Alexey Samsonov]

Hi Sylvestre,

On Tue, Feb 24, 2015 at 2:07 AM, Sylvestre Ledru <sylvestre at debian.org>
wrote:

> On 18/02/2015 23:29, Alexey Samsonov wrote:
> >
> > On Tue, Feb 17, 2015 at 6:23 PM, Anna Zaks <ganna at apple.com <mailto:
> ganna at apple.com>> wrote:
> >
> >
> >>     On Feb 17, 2015, at 4:00 PM, Alexey Samsonov <vonosmas at gmail.com
> <mailto:vonosmas at gmail.com>> wrote:
> >>
> >>
> >>     On Tue, Feb 17, 2015 at 3:37 PM, Anna Zaks <ganna at apple.com
> <mailto:ganna at apple.com>> wrote:
> >>
> >>         Unfortunately, we do rely on the Autotools to build for darwin.
> >>
> >>
> >>         The lack of proper testing is very unfortunate. In the future,
> we will either drop the dependency on Makefile/autoconf build or add the
> support for sanitizer testing.
> >>
> >>
> >>     Sorry, for some reason I had the impression that you're also more
> interested in CMake buiild :-/. Only now I noticed that recent Kuba's
> patches about -isysroot fix both makefile and CMake
> >>     build system (and he's probably not very happy about it).
> >>
> >>     I believe the effort required to port sanitizer unit tests to
> autotools is not worth it, and it's better to spend that time migrating the
> release tools to CMake. Keeping two build systems "working"
> >>     was and is a manageable, but unpleasant burden. Providing a good
> test coverage for two runtime versions is hard, and keeping two runtime
> versions "equivalent" (built with the same compiler flags)
> >>     is close to impossible.
> >
> >     I agree. The solution where we only rely on cmake build would be the
> best option.
> >
> >>
> >>     I understand that removing autotools support right now breaks your
> integration. What if we just delete autotools support from all Linux builds?
> >>
> >
> >     Yes. That is fine by me.
> >
> >
> > OK, I've removed the support for sanitizers in makefile/autoconf builds
> on Linux in r229754-r229756.
> It is possible to build LLVM & Clang with autotools and compiler-rt with
> cmake?
>

Yes, that's one of the options... Probably we can invoke cmake directly
from Makefile.

>
> Currently, dropping the autotools support is breaking the build of
> compiler-rt for llvm.org/apt/ and
> the Debian & Ubuntu packaging.
>

Could you point at the failing build? Jenkins (
http://llvm-jenkins.debian.net/) has dozens of them, I don't know where to
look. What scripts / rules do you
use to build the packages?


> I agree that the autotools support in compiler-rt was limited but it was
> doing the job correctly...
>

Is it possible to just exclude sanitizer runtimes from autotools-built
packages until all debian package build process is ported to CMake?

>
> Could you consider reverting this changes?
>
> Thanks,
> Sylvestre
> PS: I don't mind switching to cmake but here are still a few blocking bugs:
> http://llvm.org/bugs/show_bug.cgi?id=15732
>
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
>



-- 
Alexey Samsonov
vonosmas at gmail.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20150224/1bc8fd82/attachment.html>