[llvm-dev] Phabricator/Arcanist feedback

[Dan Liew via llvm-dev]

> I think it makes sense that `arc commit` only works with svn since that's
> where the repo is hosted and git is just a mirror. Phabricator's
> documentation also says that `arc commit` is for subversion, whereas `arc
> land` would be for git:
> https://secure.phabricator.com/book/phabricator/article/arcanist_diff/
>
> Anyhow, I generally create a local feature branch off of master, make the
> local commit, and create the patch via arcanist (arc diff). If the patch
> gets approved I'll merge and rebase/squash this back onto master and make
> the commit using git svn (`git svn dcommit`).

I'll try to make sure this workflow is described in the patch for the
docs I will make.

>>
>>
>> * Running the ``arc patch`` command assumes you are on a clean master
>> branch and want to apply a patch uploaded Phabricator. This is
>> pointless (and won't work) if you are already on a local branch that
>> already has the commit you want to commit to trunk.
>
>
> To clarify, is the local branch the patch you've already created, been
> approved, and is ready to land?

It has already landed. The commit was created by ``arc patch``. I
cherry-picked the commit it created on to my master branch, cleaned up
the commit message and did ``git svn dcommit``.

Thanks,
Dan.